Andras, in Ext2Directory : addFile and addDirectory

Submitted by Fabien D on Tue, 03/30/2004 - 16:56.

JNode-FS

Andras, in Ext2Directory : addFile and addDirectory are exactly the same !
I suppose it's normal. What do you think ?

addDirectoryRecord()

Submitted by blind on Tue, 03/30/2004 - 17:18.

No, they are not really the same.
Most of the stuff involved in adding a directory or a file is the same, so I have put the common stuff in addDirectoryRecord().
If you look at the source, you'll see that what addFile() and addDirectory() do is call addDirectoryRecord() with a different Ext2DirectoryRecord as parameter.

Sorry, what exactly should I think about what? Smiling

Andras

Sorry, I thought they was exactly the same

Submitted by Fabien D on Tue, 03/30/2004 - 17:34.

Of course you are right, I made a mistake : I haven't see the little difference.

But, in addDirectory, you have :
return new Ext2Entry(newINode, name, Ext2Constants.EXT2_FT_REG_FILE, fs)
Isn't it Ext2Constants.EXT2_FT_DIR instead of Ext2Constants.EXT2_FT_REG_FILE that you would like to use?

EXT2_FT_DIR

Submitted by blind on Tue, 03/30/2004 - 19:17.

Sure, thanks for spotting it, I'll correct it right away.
Andras

Please, don't correct it !

Submitted by Fabien D on Thu, 04/01/2004 - 13:49.

As I am doing abstract classes, I corrected it on my PC (sorry but I commit now). So, there is no necessity for you to commit just for this.

If already committed, that's not a problem.

some changes in CVS

Submitted by blind on Sat, 04/03/2004 - 17:53.

Hi Fabien,
Please be aware that I had to make some changes to classes in the ext2 package (Ext2Entry, Ext2Directory, Ext2File, etc). If you are still working on abstract versions of these classes, please do an update from CVS to merge with the changes.
Andras