Fix for FAT names sometimes having junk after them
| Project: | JNode FS |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Daniel Noll |
| Status: | closed |
Description
Some code in FatLfnDirEntry.getSubstring was searching for nulls from the end of the string.
A directory in my own data set had a string like this:
dir1\0\65535\65535\65535\65535...
As a result the current implementation wasn't trimming the junk from the back. I changed the code to search for the \0 from the front instead.
- Login to post comments
#1
Where is the patch?
#2
I hope this was a mistake by Daniel.
Today morning I saw one "spam post". I do not know why this issue got marked as spam.
So I marked it as not-spam. Either that removed the attachement or Daniel did not append it.
#3
It's a web site bug actually and here is how to make it happen:
- Go to File Attachment, hit Browse, select a file.
- Hit Attach, file *pretends* to be attached.
- Hit Preview Comment (note that you can't see an attachment, I assumed it was there but obviously it wasn't.)
- Post
That set of steps will result in the attachment not being on the site.
If you go directly to Preview after selecting the file it seems to work fine, although it's hard to confirm because as you've probably noticed, *another* bug with the site prevents seeing the attachment after posting even if it's present.
#4
(Re: the patch upload issue). That is not a new issue. The website has behaved as you described for as long as I can remember. But it would be nice if it was fixed.
#8
Ok, this was my fault. File uploads should work now and also the behaviour described by Daniel should not happen again.
#9
Daniel,
could you please submit the patch as a file attachement?
If it's still not working for some reason, pleasen email it to me.
Thanks, Levente
#10
Attaching.
#11
Committed.
#12
marking as fixed since the code has been commited
#14
Automatically closed -- issue fixed for two weeks with no activity.