Patch for FSTestSuite - now runable in Eclipse as well

Project:	JNode FS
Component:	Code
Category:	task
Priority:	normal
Assigned:	lsantha
Status:	patch (code needs review)

Changes done:
1. Removed usage JFuncSuite for defining TestSuites this blocks Eclipse JUnit testrunner to execute tests (i don't know why but it doesn't work). Now it is also feasible to run FSTestSuite in Eclipse with "Run-As -> Junit Test".
2. Added report generation in the fs/build.xml to generate HTML-report of testrun in fs/build/report/

Attachment	Size
fs_tests.patch	15.23 KB

#1

Submitted by caless on Tue, 03/31/2009 - 06:57.

Fixed Checkstyle issues

Attachment	Size
fs_tests_fixed_checkstyle.patch	15.28 KB

#2

Submitted by lsantha on Tue, 03/31/2009 - 07:26.

Assigned to:

Anonymous

» lsantha

#3

Submitted by lsantha on Tue, 03/31/2009 - 19:58.

The patch looks good. I integrated it.
Thank you!
Levente

#4

Submitted by caless on Tue, 03/31/2009 - 21:19.

Thank you for integrating!

I also did a test here to get rid of the jcfe.jar and jfunc.jar and different versions of junit used in JNode.
It worked fine here.
We have to make a decision if we still want to keep jfunc in the code - the latest release from jfunc is about 7 years ago ... https://sourceforge.net/project/showfiles.php?group_id=47816&release_id=...

So I'll keep you updated and submit a further patch for that. I hope this is accepted.

Regards
Stefan

#5

Submitted by caless on Fri, 04/03/2009 - 12:42.

Hi Fabien,

i hope you'll read this.
I've seen the your chatlog from yesterday.
Yestereday i was able to port the FS tests to be able to run properly in junit 4.5. This includes the @Test annotation and also using the Parameterized runner from JUnit 4.5 to achieve the different configuration on each test.

I'll provide a patch this evening.

Regards
Stefan

#6

Submitted by caless on Fri, 04/03/2009 - 22:02.

Attached the more extended version which uses only one junit version (4.5).
It also removes the dependency to jfunc.jar and jcfe.jar.
Also updated are the FS tests to the Parameterized functionality to run the tests in the JUnit 4.5 style. Only one little drawback with the new Parameterized is that there is only the testnumber (but not the description of the configuration; there are feature requests available in JUnit: http://sourceforge.net/tracker/?func=detail&atid=365278&aid=1742040&grou... and http://sourceforge.net/tracker/index.php?func=detail&aid=1630834&group_i... )

After applying this patch you need to run following commands as well:

rm core/descriptors/jcfe.xml
rm core/descriptors/jfunc.xml
rm core/lib/jfunc.jar
rm core/lib/jcfe.jar
rm distr/lib/junit-4.1.jar
mv core/lib/junit-4.5.jar core/lib/junit.jar

Kind regards
Stefan