REGRESSION: ping output is broken and throws exception

Project:JNode Net
Component:User interface
Category:bug report
Priority:normal
Assigned:cluster
Status:closed
Description

.

AttachmentSize
i2.png23.27 KB

#1

Assigned to:Anonymous» cluster

#2

Status:active» fixed

Should be fixed. I dont have networking configured to actually run ping, but this should fix the format typos

#3

Status:fixed» active

Tested: not OK
A newline is missing after attempt 0,1,... and an exception is there too.

AttachmentSize
i3.png22.83 KB

#4

Patch commited.

And for the record. Typos, in a format string are not 'regressions', they're typos. Would it really have been that hard on you to have made that change? I swear its like your really trying to get under my skin or something. I'm just here to enjoy some free time while i have it. Can you at least make some attempt to try and not ruin that for me?

#5

I will have a look ...

#6

If you used ping under JNode you knew that it worked but after your changes it didn't. This is called regression (without quotation marks). I filled an issue and tested it for you because aparently you didn't.
When you have commit rights and your are active what is wrong in expecting that you fix the code you broke?
Do you think it's fun for me to find out that commands I need and regularly use are broken?

#7

Status:active» fixed

Call it what you want, its a typo.

And no i have never used ping because any attempts i have made to setup networking in jnode has lead to exceptions and deadlocks. So yes those changes were untested, because i can't test them.

what is wrong in expecting that you fix the code you broke?

Absolutely nothing at all, its all my fault. I'm sorry i made a mistake, i'll never make another mistake again master.

#8

Do you think it's fun for me to find out that commands I need and regularly use are broken?

This is why it's a good idea to backup stable builds. Although git makes this alot easier than svn, i use a script that runs my builds for me, and backs up the last iso, so even if a build is broken, there is always a working iso to boot.

#9

Levente, your criticism of Cluster (comments above) was NOT called for.

If someone is doing a lot of work in difficult circumstances (e.g. broken networking + pressure to get the cli restructuring done and working), it is not surprising that mistakes happen.

You should be more tolerant of other peoples mistakes. You make mistakes too, and other developers don't tell you off in public for it. So kindly return the favour, and refrain from doing to the rest of us.

This project supposed to be fun. Most people will only put up with a certain amount of this kind of aggravation, then it's "Bye bye ... I'm going to find something better to do". So, next time you feel like being ... intolerant ... towards another developer, think of the possible long term consequences.

#10

Status:fixed» closed

Manually closed.