can I remove MakeSMBDeviceCommand and MakeFTPDeviceCommand ?

Submitted by Fabien D on Sat, 01/19/2008 - 09:21.

I have noticed that :

  • MakeSMBDeviceCommand and SMBMountCommand : they are both the same but the second take a mount point as argument
  • MakeFTPDeviceCommand and FTPMountCommand : they are both the same but the second take a mount point as argument

And there is the generic MountCommand, which take a device, so :

  • SMBMountCommand is equivalent to MakeSMBDeviceCommand + MountCommand
  • FTPMountCommand is equivalent to MakeFTPDeviceCommand + MountCommand

we don't need so much complicated things.
Creating devices by MakeSMBDeviceCommand and MakeFTPDeviceCommand has no meaning for me : we only want to mount a specific filesystem (and for that the command will create a device and a driver : the user don't even have to know that).

so, can I remove MakeSMBDeviceCommand and MakeFTPDeviceCommand ? or is there some particular reason for doing that ?

‹ Proposal for a better source organization JNode-FS For Newbies ›

OK, that makes

Submitted by lsantha on Sat, 01/19/2008 - 17:53.

OK, that makes sense.
Deleted.

agree

Submitted by Trickkiste on Sat, 01/19/2008 - 13:01.

Hi,

I agree to remove the commands, I think the user should be able to do that with one command.

greetings,
Andreas